[azeventhubs,azservicebus] Updating to use the latest nhooyr.io/websocket package in both servicebus and eventhubs.#20335
Merged
richardpark-msft merged 1 commit intoAzure:mainfrom Mar 14, 2023
Conversation
Member
Author
|
/azp run go - azeventhubs |
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ebus and eventhubs. * Expanding the websockets descriptions and tests to go end-to-end. Prior tests weren't closing the connection and were hiding an error that was coming back from the underlying package. * The examples also document how to use an HTTP proxy with websockets, which is a common combination. * One of the tests also contains the necessary incantations to make it the entire websocket conversation wireshark-able.
richardpark-msft
force-pushed
the
sbeh-nhoory
branch
from
3765578 to
65f3ed7
Compare
Member
Author
|
/azp run go - azeventhubs |
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates us to
nhooyr.io/websocket v1.8.7which removed the gin-gonic dependency, so we no longer have to hardcode a reference to it in our go.mod.EventHubs appears to have a bug with both the older and newer websockets package where the underlying websocket returns an EOF error when closing. It appears the remote service is closing the connection immediately and not sending the second part of the "websocket close" handshake. Still under investigation, but checking in the updated dep and a test demonstrating it.
Partially fixes #16924